Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Add Matching resource to NewGossConfig() #280

Merged

Conversation

OmarDarwish
Copy link
Contributor

Fixes #278

@OmarDarwish OmarDarwish changed the title Add Matching resource to NewGossConfig() [bugfix] Add Matching resource to NewGossConfig() Sep 5, 2017
@aelsabbahy
Copy link
Member

Looks good. Can you add a test for this in the integration-tests folder?

@OmarDarwish
Copy link
Contributor Author

Added. When I ran it locally, the tests I added pass for all architectures. The only failure was for the autofs service on . It was not running for precise-64. Not sure why, but it seems unrelated to my changes:

++ docker_exec /goss/precise/goss-linux-amd64 --vars /goss/vars.yaml -g /goss/precise/goss.yaml validate
++ docker exec goss_int_test_precise_amd64 /goss/precise/goss-linux-amd64 --vars /goss/vars.yaml -g /goss/precise/goss.yaml validate
+ out='.........................F........................................................

Failures/Skipped:

Service: autofs: running:
Expected
    <bool>: false
to equal
    <bool>: true

Total Duration: 1.005s
Count: 82, Failed: 1, Skipped: 0'

@OmarDarwish
Copy link
Contributor Author

Looks like it passed on Travis though 🤷‍♂️

@elliotweiser
Copy link
Contributor

@OmarDarwish I've encountered that as well when attempting to reproduce the integration test suite on my laptop. There appear to be several differences between the Travis CI environment and Docker for Mac on a development laptop that makes it difficult to reproduce. To name a few:

  • Package version differences on several docker containers
  • Autofs not running on the precise container
  • Archlinux not starting correctly

Definitely worth investigating, but in a separate change/thread.

@aelsabbahy
Copy link
Member

Seen it myself (fedora laptop), haven't followed up on it. I've been using Travis CI as a source of Truth.

I'm guessing it's related to the storage driver for docker on Ubuntu.

@aelsabbahy aelsabbahy merged commit 5e1f546 into goss-org:master Sep 12, 2017
BenjaminHerbert pushed a commit to BenjaminHerbert/goss that referenced this pull request May 28, 2020
* Fixes goss-org#278

* Add integration tests for matching resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants