Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application crashes at invalid endpoint #22

Open
aemmadi opened this issue Oct 15, 2020 · 1 comment · May be fixed by #23
Open

Application crashes at invalid endpoint #22

aemmadi opened this issue Oct 15, 2020 · 1 comment · May be fixed by #23
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@aemmadi
Copy link
Owner

aemmadi commented Oct 15, 2020

  • If the :user/:repo is invalid, the application times out and crashes
@aemmadi aemmadi added bug Something isn't working good first issue Good for newcomers labels Oct 15, 2020
@klee214
Copy link

klee214 commented Oct 15, 2020

seems like there should be further exception handler might be needed here! I will give it a shot!

  const readme = await axios.get(
    `https://api.github.com/repos/${user}/${repo}/readme`
  );

klee214 added a commit to klee214/fastdocs that referenced this issue Oct 15, 2020
@klee214
fix: invalid username or repos, timeout error aemmadi#22
fc72ead
@klee214 klee214 linked a pull request Oct 15, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: invalid username or repos, timeout error #22 klee214/fastdocs
2 participants
@aemmadi @klee214