New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript rewrite #629
Typescript rewrite #629
Conversation
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Nail biter waiting for those green checks to appear. Going to get myself a drink now 🍺 |
Signed-off-by: Peter Kottas <petokottas@gmail.com>
…ditor into typescript-rewrite
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Oh shit, this is massive! There's no way for me to review it so I'll probably just check if and how it works locally and then merge. We might have to fix a couple of things as the next releases come rolling in. |
Yeah that's what I though. +51,913, −106,061, Files changed 289 says it all. I did extensive testing and all seems fine. But please, by all means, dig in ;) Also I assumed this release will be 0.6.0 and wrote upgrade docs. Not extensive and it can be changed, just want to make sure I won't forget. |
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
…ditor into typescript-rewrite
Ok this seems to be pretty stable now. I am branching off and working on plugins as discussed in #580. I know it's around Christmas and you might be busy with more enjoyable things, but if we could merge this in (after testing), it would be swell :) I have few more features planned that all need to branch of this. So it will be a huge relief when this is done. |
Hi there, any chance you managed to look at this? I know Christmas time can be busy but I was hoping to get this merged in along with #630 as I have plenty of work to take advantage of this on our side. |
Sorry, pre-christmas was just insane. I'll try to get it done on on Saturday/Sunday |
Awesome mate! Thanks for info, I am here if you need any help with these. |
Awesome! Looks like everything works perfectly |
Phew :) |
🎉 It's alive 🎉
Highlights of this PR:
Admittedly, this is probably biggest PR in the history of universe :D I rly tried to check everything to make your life simple. Hoping it will go as smooth as possible. Also I am here for any questions you might have.