Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript rewrite #629

Merged
merged 24 commits into from Dec 22, 2018
Merged

Typescript rewrite #629

merged 24 commits into from Dec 22, 2018

Conversation

PeterKottas
Copy link
Collaborator

🎉 It's alive 🎉

Highlights of this PR:

  • Typescript rewrite done
  • All tests working
  • Prettier runs by reading tslint config.
  • f12 navigates between projects properly
  • Fixed a gazilion weird little nuances that had to do with types, typos or problems in code.
  • This also fixes a lot of existing comments that were pointing to various issues. Most of these had something to do with es-link or flow types in general
  • Changed tooling section in readme
  • Added a Known issue in readme (sometimes vscode locks declaration files so you have to run build again)
  • Removed all traces of flow and generally cleaned up the code
  • Declarations are exported along with js files and js.maps. That means typescript people will love us.

Admittedly, this is probably biggest PR in the history of universe :D I rly tried to check everything to make your life simple. Hoping it will go as smooth as possible. Also I am here for any questions you might have.

Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
@PeterKottas
Copy link
Collaborator Author

Nail biter waiting for those green checks to appear. Going to get myself a drink now 🍺

Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
@aeneasr
Copy link
Collaborator

aeneasr commented Dec 16, 2018

Oh shit, this is massive! There's no way for me to review it so I'll probably just check if and how it works locally and then merge. We might have to fix a couple of things as the next releases come rolling in.

@PeterKottas
Copy link
Collaborator Author

PeterKottas commented Dec 16, 2018

Yeah that's what I though. +51,913, −106,061, Files changed 289 says it all. I did extensive testing and all seems fine. But please, by all means, dig in ;)

Also I assumed this release will be 0.6.0 and wrote upgrade docs. Not extensive and it can be changed, just want to make sure I won't forget.

Signed-off-by: Peter Kottas <petokottas@gmail.com>
Signed-off-by: Peter Kottas <petokottas@gmail.com>
@PeterKottas
Copy link
Collaborator Author

Ok this seems to be pretty stable now. I am branching off and working on plugins as discussed in #580. I know it's around Christmas and you might be busy with more enjoyable things, but if we could merge this in (after testing), it would be swell :) I have few more features planned that all need to branch of this. So it will be a huge relief when this is done.

Signed-off-by: Peter Kottas <petokottas@gmail.com>
@PeterKottas
Copy link
Collaborator Author

Hi there, any chance you managed to look at this? I know Christmas time can be busy but I was hoping to get this merged in along with #630 as I have plenty of work to take advantage of this on our side.

@aeneasr
Copy link
Collaborator

aeneasr commented Dec 21, 2018

Sorry, pre-christmas was just insane. I'll try to get it done on on Saturday/Sunday

@PeterKottas
Copy link
Collaborator Author

Awesome mate! Thanks for info, I am here if you need any help with these.

@aeneasr
Copy link
Collaborator

aeneasr commented Dec 22, 2018

Awesome! Looks like everything works perfectly

@aeneasr aeneasr merged commit 561dcdb into react-page:master Dec 22, 2018
@PeterKottas
Copy link
Collaborator Author

Phew :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants