Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check in CI that the build doesn't generate warnings #117

Closed
sonmarcho opened this issue Apr 11, 2024 · 3 comments
Closed

Check in CI that the build doesn't generate warnings #117

sonmarcho opened this issue Apr 11, 2024 · 3 comments
Assignees
@Nadrieril
Labels
A-CI Pertains to Continuous Integration C-improvement

Comments

@sonmarcho
Copy link
Member

sonmarcho commented Apr 11, 2024 •
edited

It can happen that the compilation generates warnings (for instance, clippy warnings): I want to make sure it doesn't happen (i.e., all warnings are addressed before we merge).
@Nadrieril

This comment was marked as resolved.

Sign in to view
@sonmarcho sonmarcho changed the title Fix a warning during the build Check in CI that the build doesn't generate warnings Apr 19, 2024
@Nadrieril Nadrieril added A-CI Pertains to Continuous Integration C-improvement labels Apr 23, 2024
@Nadrieril Nadrieril self-assigned this May 14, 2024
@Nadrieril
Copy link
Member

That's already the case today for the rust side: we pass -D warnings to cargo when building.

@Nadrieril
Copy link
Member

And for the ml side also. I just checked both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nadrieril Nadrieril

Labels
A-CI Pertains to Continuous Integration C-improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nadrieril @sonmarcho