Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add requirements.txt #124

Closed
LahkLeKey opened this issue Nov 26, 2021 · 6 comments
Closed

Add requirements.txt #124

LahkLeKey opened this issue Nov 26, 2021 · 6 comments

Comments

@LahkLeKey
Copy link

Hey, could you add a requirements.txt to the main git for easy pip installs?

you can do this by running pip freeze > requirements.txt

which will allow other developers to run pip install -r "requirements.txt" for easy dependency installation

@aeon0
Copy link
Owner

aeon0 commented Nov 26, 2021

But there is already an environment.yml. No need to have that redundant I would say.

@aeon0 aeon0 closed this as completed Nov 26, 2021
@LahkLeKey
Copy link
Author

LahkLeKey commented Nov 27, 2021

That requires conda but ok

@aeon0
Copy link
Owner

aeon0 commented Nov 27, 2021

I thought about it again and I see your point. We currently only have pip requirements in the environment.yml, so there would be no harm in having a requirements.txt. And its not like dependencies change a lot.
Only thing is, that I dont think you can enforce a min python version. Can you? Botty needs >=3.8.

@aeon0 aeon0 reopened this Nov 27, 2021
@aeon0
Copy link
Owner

aeon0 commented Dec 15, 2021

There will be conda dependencies with upcoming ocr feature. Thus it will be unpractical to give this feature to users just to take it away again.

@aeon0 aeon0 closed this as completed Dec 15, 2021
@LahkLeKey
Copy link
Author

Its not that big of a deal I just put my own in my test branch. As for "conda dependencies" conda is just a package manager. Nothing installed via conda is specific to conda. It is just can be a nice alternative if you use alot of data science related packages or juptyr.

@aeon0
Copy link
Owner

aeon0 commented Dec 17, 2021

@LahkLeKey Installing things via conda is a bit more than just python modules. It can also install and set-up dependencies outside of python modules such as cuda etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants