Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于ESLint检测未修复的问题与改进建议 #47

Closed
gaoac opened this issue Feb 2, 2020 · 2 comments
Closed

关于ESLint检测未修复的问题与改进建议 #47

gaoac opened this issue Feb 2, 2020 · 2 comments

Comments

@gaoac
Copy link
Contributor

gaoac commented Feb 2, 2020

存在问题

项目中目前引入了 ESLlint,但是执行 lint 检测,发现仍尚存不少 error。

Code_2020-02-02 11-08-16@2x

改进建议

结合 ESLint、prettier、husky、lint-staged 进行标准编程规范自动化验证,保证 git commit 时代码必须检测通过方可正常 commit,以此保证大伙规范的统一性。

@aermin
Copy link
Owner

aermin commented Feb 2, 2020

感谢建议👍,你的建议很好,公司的项目就有结合那些做pre-commit的操作,这个项目偏向于自己写着玩的(有些代码很潦草😂),像你一样愿意提pr(多人合作开发)的很少很少,所以我就没有很迫切去做pre-commit

@gaoac
Copy link
Contributor Author

gaoac commented Feb 2, 2020

@aermin 嗯,这样的话就没必要太严格了,加个 prettier,统一格式化就行了

@gaoac gaoac closed this as completed Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants