Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment schema #24

Merged
merged 7 commits into from
Sep 13, 2018
Merged

Update comment schema #24

merged 7 commits into from
Sep 13, 2018

Conversation

danielpassos
Copy link
Contributor

@danielpassos danielpassos commented Aug 30, 2018 •
edited

secondsun
secondsun approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@secondsun secondsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 works on my machine

psturc
psturc approved these changes Sep 5, 2018
View reviewed changes
Copy link

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Verified locally.

@wtrocki
Copy link
Contributor

wtrocki commented Sep 6, 2018

@danielpassos Sorry for holding this for so long!
Reviewed. Really really good work!

@danielpassos
Copy link
Contributor Author

@wtrocki Not worries. Let's wait to have the server side schema change PR merged before merge it.

@danielpassos danielpassos merged commit 8948f5a into aerogear-attic:master Sep 13, 2018
@danielpassos danielpassos deleted the comments-query branch September 13, 2018 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

@secondsun secondsun secondsun approved these changes

@psturc psturc psturc approved these changes

@darahayes darahayes Awaiting requested review from darahayes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@danielpassos @wtrocki @secondsun @psturc