This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Fix source map issues #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| }); | ||
|
|
||
| // Generated source map URL removal task | ||
| grunt.registerTask('post-uglify', function( custom ) { |
There was a problem hiding this comment.
It doesn't look like this task is needed.
doesn't look like "dist/aerogear.js" ever gets "sourceMappingURL" written to it, so no need to run the replace
|
@kborchers custom builder also updated locally, works good |
…ption with preserveComments to fix broken source maps. Fixes AEROGEAR-805
|
@lholmquist Can you take a look at this simpler fix? Also, make sure it works with builder? |
|
that was much simpler |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.jboss.org/browse/AEROGEAR-805