This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Auth:Rest and Pipeline:Rest - Remove Auth-Token. Fixes AGJS-26 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lholmquist I would appreciate a review of this and verification that it works with TODO |
|
👍 any reason why we can't default the "data" to applicaiton/json so the user doesn't have to specify it for login/enroll a couple tweaks on TODO, but it works, I'll add a JIRA and send a PR once this gets merged |
|
I think we should default to what most forms post data as and only allow the user to specify application/json. It's always something we could change later if users really ask for it. |
|
Landed in 0c68ea0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.