DataManager - Memory - initialize store to empty array - AGJS-105 #87

lfryc · 2013-12-03T21:29:34Z

lfryc · 2013-12-03T21:34:24Z

As this obviously fixes the issue and additionally it passes all tests,

That change makes some tests to fail (WebSQL) as there is some inheritance problem:
WebSQL calls Memory: https://github.com/aerogear/aerogear-js/blob/master/src/data-manager/adapters/websql.js#L455
but then it resolves to invocation of addDataRecord method
https://github.com/aerogear/aerogear-js/blob/master/src/data-manager/adapters/memory.js#L251
that doesn'e exist in inheritance chain of WebSQL datamanager:

Shouldn't we test all data manager implementations for their initial state?

tolis-e · 2013-12-04T09:50:55Z

@lfryc In case you initialize data to [] in Data manager base.js

or modify the getData function:

to return data || [];

then you also need to change line:

to if ( this.getData() && this.getData().length !== 0 ) {

and all the tests are passing. I don't see any inheritance problem.

To be honest, I don't like the initialization this.setData( [] ); here:

lholmquist · 2013-12-04T13:25:17Z

to if ( this.getData() && this.getData().length !== 0 ) {

lfryc · 2013-12-04T14:50:14Z

+1 updated pull request

lholmquist · 2013-12-04T14:59:01Z

👍

lholmquist · 2013-12-04T14:59:06Z

DataManager Base - return empty array if store is empty. AGJS-105

0b2b76a

lholmquist closed this Dec 4, 2013

Provide feedback