This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
AGPUSH-232 #16
Merged
AGPUSH-232 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| @OPTIONS | ||
| public Response crossOriginForInstallations(@Context HttpHeaders headers) { | ||
| System.out.println("IN OPTIONS"); |
Conflicts: src/main/java/org/jboss/aerogear/aerodoc/rest/Login.java
| public class CorsExceptionHandler implements ExceptionMapper<EJBException> { | ||
| @Override | ||
| public Response toResponse(final EJBException exception) { | ||
| System.out.println("Handling Unauthorized exception"); |
|
since the 0.2.1 JAR of the java-client is not present, the build will fail Can you make travis happy, similar to here: (make sure you use the correct brnach) |
…ll receive messages again
| @@ -48,11 +49,13 @@ public LeadSender() { | |||
| public void sendLeads(List<String> users, Lead lead) { | |||
|
|
|||
| Map categories = new HashMap(); | |||
|
|
|||
| categories.put("lead", "version=" + leadVersion++); //TODO manage the version properly | |||
| UnifiedMessage unifiedMessage = new UnifiedMessage.Builder() | |||
| .pushApplicationId(getActivePushConfig().getPushApplicationId()) | |||
There was a problem hiding this comment.
what if there is no (active) PushConfig ? This will throw a NPE
|
👍 |
|
landed in ba24eea |
|
Again, that landed message was unnecessary. Especially since this PR landed multiple commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.