Simplification #17
Simplification #17
Conversation
var pushConfig = {
pushServerURL: "<pushServerURL e.g http(s)//host:port/context >",
alias: "<alias e.g. a username or an email address optional>",
android: {
senderID: "<senderID e.g Google Project ID only for android>",
variantID: "<variantID e.g. 1234456-234320>",
variantSecret: "<variantSecret e.g. 1234456-234320>"
},
ios: {
variantID: "<variantID e.g. 1234456-234320>",
variantSecret: "<variantSecret e.g. 1234456-234320>"
}
};
|
Looks like the |
|
Or the real documentation... |
|
moving the readme to the site was part of aerogear/aerogear.org#264 and #16 |
|
And does these PR reflects the changes that are present in this PR ? On Tue, Mar 11, 2014 at 10:50 AM, Erik Jan de Wit
|
Oh, ok - was not aware of that PR, while reading this one |
|
No, we need to update the documentation once we release and include a migration document as well |
|
Looks like a link to this file is missing from the guides index file: http://staging.aerogear.org/docs/guides/aerogear-cordova/AerogearCordovaPush/ |
|
Reading the referenced discussion thread, from this PR, I think this (inside of the staged documentation) is now incorrect:
Reading the thread, I have the impression the following is the latest: `` `` But that can be easily fixed in another documentation PR |
|
This document is linked from the guides index file under User Guides > AeroGear Cordova PushPlugin and from Home > Cordova > Learn More |
|
Like I said before we need to update the documentation for this change in API once we release a new version the documentation is still referencing the current release! |
|
@ doc link: Awesome! I guess I just missed it |
|
The following https://gist.github.com/matzew/dabc10c19d0e146dfae1 it causes the |
|
very funny; |
|
Tried a few more apps: they all work and did register w/ the UPS. However on the first two apps, I got the Apps nr. 3,4,5 worked all immediately out of the box |
|
👍 let's |
|
Not sure this is a good test idea, but I gave it a shot on iOS 7.1 (w/ Xcode 5.1) The build reports these errors: |
|
Sorry, I know I am late to this party. Just saw the discussion thread for these changes. I love the rest of the changes. Great simplifications. |
|
@success handler: fair point On Thursday, March 13, 2014, Keith D. Moore notifications@github.com
Sent from Gmail Mobile |
|
Yes, this is a valid use case for the success handler |
|
@matzew seems like there are issues with cordova and xcode 5.1 |
|
yep, saw the blog last night already On Thu, Mar 13, 2014 at 11:39 AM, Erik Jan de Wit
Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ |
|
How did you guys find out about this? The hard way? I am reverting back to 5.0.2. Thanks for sharing this!
|
|
@keithdmoore in the blog that @edewit mentionned some workarounds mentioned. In ther sametime there is some pressure on Cordova's mailing list to ship quickly a 3.4.1 version that contains some fixes. |
|
Hey @keithdmoore
Via Twitter :-) I follow @brianleroux there - and he retweeted this: |
|
Should we merge this now ? |
|
Let's add the success handler again, seems that it's needed |
|
Now added the successCallback again API looks like push.register(onNotification, successCallback, errorHandler, pushConfig);
function successCallback() {
console.log('registration successful');
} |
|
Great Pecked out from my iPhone
|
|
Is this PR good to merge ? |
|
landed 9d16f15 |
as discussed on the mailing list a simplification of the push plugin API