Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

changed flow to always invoke #46

Closed
wants to merge 1 commit into from
Closed

Conversation

edewit
Copy link
Member

@edewit edewit commented Aug 22, 2014

No description provided.

@cvasilak
Copy link
Contributor

@edewit i am on it

@cvasilak
Copy link
Contributor

@edewit after testing with both the existence of 'content-avalable' or not, I think the way it is on this PR defeats the purpose of doing 'background fetch', that is the js callback is now called once the notification is clicked by the user from the drawer (that is the else executed in here)

opened PR #47 which in my tests, handled both background and normal notifications correctly

let me know what you think

@edewit
Copy link
Member Author

edewit commented Aug 22, 2014

but I want the js callback to be called so that I can fetch the data on the quickstarts the https://github.com/aerogear/aerogear-push-quickstarts/blob/fb97b9ed981b8bf78943758e15ef321ee34bdc77/client/contacts-mobile-ios-client/Contacts/AGAppDelegate.m#L60-L79 is called twice as well once to fetch the content and once to navigate to the newly fetched data, that is what I want to have for the push plugin as well

@matzew
Copy link
Contributor

matzew commented Aug 22, 2014

do you guys feel comfortable including this in 1.0.0 ?
Or should we better do this for 1.0.1 ?

On Fri, Aug 22, 2014 at 5:04 PM, Erik Jan de Wit notifications@github.com
wrote:

but I want the js callback to be called so that I can fetch the data on
the quickstarts the
https://github.com/aerogear/aerogear-push-quickstarts/blob/fb97b9ed981b8bf78943758e15ef321ee34bdc77/client/contacts-mobile-ios-client/Contacts/AGAppDelegate.m#L60-L79
is called twice as well once to fetch the content and once to navigate to
the newly fetched data, that is what I want to have for the push plugin as
well


Reply to this email directly or view it on GitHub
#46 (comment)
.

Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf

@edewit
Copy link
Member Author

edewit commented Aug 22, 2014

@matzew I think it's fine to include this... just seems that @cvasilak and I seem to differ on when the js callback should be called. I think the best solution is for it to be invoked twice.

@matzew
Copy link
Contributor

matzew commented Aug 25, 2014

looks like some rebase error happened - #48 was opened to replace this one

@matzew matzew closed this Aug 25, 2014
@edewit edewit deleted the AGCORDOVA-26 branch August 25, 2014 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants