Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Update admin #66

Merged
merged 11 commits into from Aug 7, 2013
Merged

Update admin #66

merged 11 commits into from Aug 7, 2013

Conversation

abstractj
Copy link
Contributor

No description provided.

private static final String DEFAULT_PASSWORD = "123";

@POST
@Path("/enroll")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we added the enroll inside of this class since the AG Security (e.g. the JS client), by default, uses ``auth/enroll` for the endpoint name. Sure that can be overridden, but if I recall correctly @lholmquist did prefer it that way, as it currently is.

But for a cleaner user management, I do agree that the enroll should be part of the "Admin / User Mgmt" Endpoint.

Looks like @lholmquist needs to update some JS config :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matzew I can do it if we are in agreement, np at all

I will wait for the feedback from @lholmquist too

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since i haven't written any code to "enroll" anyone yet, i think we can change this ;)

i just wanted it to be consistent with the client libs

@lholmquist
Copy link
Member

👍
tested with the latest snapshots, and all good. i've updated the admin ui for the new flow of first login -> change -> re-login, will send that PR shortly

@lholmquist lholmquist mentioned this pull request Aug 6, 2013
@matzew
Copy link
Contributor

matzew commented Aug 7, 2013

👍

tested locally - works great

@matzew matzew merged commit 9946e5a into aerogear:master Aug 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants