Conversation
private static final String DEFAULT_PASSWORD = "123"; | ||
|
||
@POST | ||
@Path("/enroll") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we added the enroll
inside of this class since the AG Security (e.g. the JS client), by default, uses ``auth/enroll` for the endpoint name. Sure that can be overridden, but if I recall correctly @lholmquist did prefer it that way, as it currently is.
But for a cleaner user management, I do agree that the enroll
should be part of the "Admin / User Mgmt" Endpoint.
Looks like @lholmquist needs to update some JS config :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matzew I can do it if we are in agreement, np at all
I will wait for the feedback from @lholmquist too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since i haven't written any code to "enroll" anyone yet, i think we can change this ;)
i just wanted it to be consistent with the client libs
👍 |
👍 tested locally - works great |
No description provided.