This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
Example app skeleton #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be now finished, please do final review. |
|
@wojta there are a lot of files in this PR which makes it a bit hard to review. Is there anyway to tell which files are auto-generated and which files are not. I think we don't need to review the auto generated files. or is there some specific commits we should review? |
|
@wei-lee There are unfortunately some files, that are also generated. But they can't be removed from the commits. But only interesting code is in |
Added authenticate button
Removed svgs from the android project
Added auth page
ziccardi
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/AEROGEAR-2227
Core handling will be in separate PR.