This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
AEROGEAR-8193 - initial batch of integration tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliok
requested review from
danielpassos,
darahayes,
StephenCoady and
wtrocki
as code owners
aliok
changed the title
aliok
commented
Dec 12, 2018
| @@ -3,7 +3,7 @@ | |||
| /* Basic Options */ | |||
| "target": "ES2017", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017','ES2018' or 'ESNEXT'. */ | |||
| "module": "commonjs", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | |||
| "lib": ["es2017", "esnext.asynciterable"], /* Specify library files to be included in the compilation. */ | |||
| "lib": ["es2017", "esnext.asynciterable", "dom"], /* Specify library files to be included in the compilation. */ | |||
There was a problem hiding this comment.
This was necessary otherwise apollo-http-link-common's type defs were not compiling:
https://circleci.com/gh/aerogear/apollo-voyager-server/59?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
aliok
changed the title
|
@darahayes ready for review and verification |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 kind of integration tests:
@darahayes ready for review!