Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lint errors generated by golangci-lint #133

Closed
ankithans opened this issue Jul 5, 2021 · 3 comments · Fixed by #105
Closed

Fix lint errors generated by golangci-lint #133

ankithans opened this issue Jul 5, 2021 · 3 comments · Fixed by #105
Assignees
@ankithans
Labels
good first issue Good for newcomers
Projects
Charmil WIP

Comments

@ankithans
Copy link
Member

No description provided.

@ankithans ankithans added the good first issue Good for newcomers label Jul 5, 2021
@wtrocki
Copy link
Contributor

wtrocki commented Jul 5, 2021

Do you mind fixing it and also removing some examples code that is not relevant

@ankithans ankithans self-assigned this Jul 5, 2021
@ankithans ankithans added this to To do in Charmil WIP via automation Jul 5, 2021
@ankithans
Copy link
Member Author

let's remove date example that we have and add generic example

@wtrocki
Copy link
Contributor

wtrocki commented Jul 5, 2021

Good idea.

@ankithans ankithans linked a pull request Jul 5, 2021 that will close this issue
refactor RuleConfig + overriding default values #105
Merged
4 tasks
@ankithans ankithans moved this from To do to Review in progress in Charmil WIP Jul 5, 2021
Charmil WIP automation moved this from Review in progress to Done Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankithans ankithans

Labels
good first issue Good for newcomers
Projects
Charmil WIP
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor RuleConfig + overriding default values aerogear/charmil
2 participants
@wtrocki @ankithans