Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update charmil_i18n docs #163

Closed
ankithans opened this issue Jul 20, 2021 · 1 comment · Fixed by #209
Closed

Update charmil_i18n docs #163

ankithans opened this issue Jul 20, 2021 · 1 comment · Fixed by #209
Assignees
Labels
enhancement New feature or request
Projects

Comments

@ankithans
Copy link
Member

i18n docs is outdated. One more concern - We may provide i18n wrapper from core, to avoid unnecessary boilerplate in the actual CLI. It will be only 4 lines of code if we include i18n wrapper in core. else it's 120 lines extra.

@ankithans ankithans added the enhancement New feature or request label Jul 20, 2021
@ankithans ankithans added this to To do in Charmil WIP via automation Jul 20, 2021
@namit-chandwani
Copy link
Member

We may provide i18n wrapper from core, to avoid unnecessary boilerplate in the actual CLI. It will be only 4 lines of code if we include i18n wrapper in core. else it's 120 lines extra.

I second this.
Apart from the factory-related issues (which will be resolved through #162), I don't see any problem in keeping the i18n package in core itself.

@ankithans ankithans self-assigned this Aug 5, 2021
@ankithans ankithans moved this from To do to In progress in Charmil WIP Aug 5, 2021
@ankithans ankithans mentioned this issue Aug 8, 2021
9 tasks
Charmil WIP automation moved this from In progress to Done Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Charmil WIP
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants