Feature to disable a validation rule

[ankithans]

User should be able to disable a rule, by passing a boolean "enable". Default set to true.

Current

type RuleOptions struct {
	Verbose      bool
	SkipCommands map[string]bool
}

Proposed

type RuleOptions struct {
	Disable       bool
	Verbose      bool
	SkipCommands map[string]bool
}

[ankithans]

I found two approaches to do this -

• Stop rule from executing from RuleExecutor(means donot add the particular rule into rules array to execute)
• add rules to executor; execute the rule and inside each rule check if it is disabled - return empty errors.

I think first one is good? Need suggestions to proceed @aerogear/charmil

[jackdelahunt]

So what your saying in option 1 is to check before we add all of the rules here? If this is where you are thinking about I would maybe suggest option 2 as option 1 feels like it is hidden away and is not an obvious place where we do that check.

Option 2 which should just need an edit to this for loop here I think so adding the check here would just make more sense.... for me atleast.

[wtrocki]

option 1 for me. but both are acceptable

[ankithans]

Option 2 which should just need an edit to this for loop here I think so adding the check here would just make more sense.... for me atleast.

here it cannot be done, as rule interface only has validate method, no access to RuleOptions. Let's go with option 1

and in 2nd opt, it need to be done here in each rule - https://github.com/aerogear/charmil/blob/main/validator/rules/length.go#L43