Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: example builder utility #223

Merged
merged 1 commit into from
Aug 11, 2021
Merged

feat: example builder utility #223

merged 1 commit into from
Aug 11, 2021

Conversation

ankithans
Copy link
Member

@ankithans ankithans commented Aug 11, 2021 •
edited

Closes #218

Description

  • Example builder utility from charmil-core

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

Checklist

  • Documentation added for the feature
  • CI and all relevant tests are passing
  • Code Review completed
  • Verified independently by reviewer

Screenshots (if appropriate):

@ankithans ankithans added the enhancement New feature or request label Aug 11, 2021
@ankithans ankithans requested a review from a team August 11, 2021 08:58
@ankithans ankithans self-assigned this Aug 11, 2021
@wtrocki wtrocki merged commit 8b438c1 into main Aug 11, 2021
@wtrocki wtrocki deleted the example-builder branch August 11, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtrocki wtrocki wtrocki approved these changes

Assignees

@ankithans ankithans

Labels
enhancement New feature or request publish-website requires-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Examples builder that provides base command instead of specifying command as string etc.
2 participants
@ankithans @wtrocki