Ensure submenu items are obvious to end user #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a few changes in order for the navigation menu to appear as if it has submenu items. * Add ids to each page so that they can be uniquely identified when it comes to determining which one is active. This is important for styling purposes. * Remove the top Menu bar from the navmenu to match the other show case applications. * Add some styling for active and submenu items so that they are more obvious to the end user. * Format any touched files.
|
@wei-lee @ciaranRoche Mind taking a look? |
|
👀 |
wei-lee
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a few changes in order for the navigation menu
to appear as if it has submenu items.
Add ids to each page so that they can be uniquely identified when
it comes to determining which one is active. This is important for
styling purposes.
Remove the top Menu bar from the navmenu to match the other show
case applications.
Add some styling for active and submenu items so that they are
more obvious to the end user.
Format any touched files.