Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone boilerplate using a tag #105

Closed
lucasbento opened this issue Sep 18, 2017 · 12 comments
Closed

Clone boilerplate using a tag #105

lucasbento opened this issue Sep 18, 2017 · 12 comments

Comments

@lucasbento
Copy link
Collaborator

The code should clone the boilerplate using a tag otherwise updates on the structure of the boilerplate may cause a bunch of issues here.

Block of code to change: https://github.com/graphql-community/create-graphql/blob/master/packages/generator/src/app/index.js#L38-L42

Depends on https://github.com/entria/graphql-dataloader-boilerplate/issues/62.

cc @graphql-community/contributors.

@shimulch
Copy link

Hi, Is this issue open? Can I have a try?
Also how a tag should be selected to be cloned?

@felippepuhle
Copy link
Collaborator

Go ahead @shimulch

@lucasbento
Copy link
Collaborator Author

@shimulch: hey, of course!

We should define a specific tag or commit hash in the generator to clone the repo, that variable should be easy to change since we can keep increasing it based on the boilerplate commits/releases.

I think a commit hash is easier for now since it doesn't require any changes in the boilerplate code.

I can't point the file to change it right now because I'm on cellphone but it should be in the generator-graphql init command.

@felippepuhle: can you specify which commit hash is the best to clone the boilerplate at the moment? I think it should be one before the changes to the loaders.

@shimulch
Copy link

@lucasbento Thanks for clarifications.
Here you can see my work so far.

master...shimulch:feature/clone_boilerplate_using_a_tag

It can now checkout to a specific commit hash after cloning the boilerplate. Now how you suggest to have a controllable variable for this task?

@lucasbento
Copy link
Collaborator Author

@shimulch: nice work!

I think you can keep it at the top as constant along with repository so it can be easily changed.

@sibelius, @felippepuhle, @JCMais: can any of you tell me a commit hash to use?

@shimulch
Copy link

I kept the last commit from master branch as commit hash. And its on a const to be changed.

@felippepuhle
Copy link
Collaborator

I guess the last commit from master is a good start. We could define this later, great job!

@shimulch
Copy link

@felippepuhle I have already put the last has from master in the PR. :-)

@shimulch
Copy link

#109

@lucasbento
Copy link
Collaborator Author

Fixed on #109, thank you for the great help, @shimulch.

@felippepuhle
Copy link
Collaborator

Yeah, I saw that @shimulch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants