-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clone boilerplate using a tag #105
Comments
Hi, Is this issue open? Can I have a try? |
Go ahead @shimulch |
@shimulch: hey, of course! We should define a specific tag or commit hash in the generator to clone the repo, that variable should be easy to change since we can keep increasing it based on the boilerplate commits/releases. I think a commit hash is easier for now since it doesn't require any changes in the boilerplate code. I can't point the file to change it right now because I'm on cellphone but it should be in the generator-graphql init command. @felippepuhle: can you specify which commit hash is the best to clone the boilerplate at the moment? I think it should be one before the changes to the loaders. |
@lucasbento Thanks for clarifications. master...shimulch:feature/clone_boilerplate_using_a_tag It can now checkout to a specific commit hash after cloning the boilerplate. Now how you suggest to have a controllable variable for this task? |
@shimulch: nice work! I think you can keep it at the top as constant along with @sibelius, @felippepuhle, @JCMais: can any of you tell me a commit hash to use? |
I kept the last commit from master branch as commit hash. And its on a const to be changed. |
I guess the last commit from master is a good start. We could define this later, great job! |
@felippepuhle I have already put the last has from master in the PR. :-) |
Yeah, I saw that @shimulch, thanks! |
The code should clone the boilerplate using a tag otherwise updates on the structure of the boilerplate may cause a bunch of issues here.
Block of code to change: https://github.com/graphql-community/create-graphql/blob/master/packages/generator/src/app/index.js#L38-L42
Depends on https://github.com/entria/graphql-dataloader-boilerplate/issues/62.
cc @graphql-community/contributors.
The text was updated successfully, but these errors were encountered: