This repository has been archived by the owner on May 31, 2019. It is now read-only.
Top level auth config for server #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The direction of this PR looks good. |
|
@darahayes Actually you may be right. We may not need session for our needs. It's up to investigation. |
|
Verified that this is working and waiting for @StephenCoady merge to integrate this into Apollo 2.0 |
wtrocki
changed the title
4 tasks
Pull Request Test Coverage Report for Build 522
💛 - Coveralls |
darahayes
reviewed
Aug 21, 2018
server/config/index.js
Outdated
| const port = process.env.HTTP_PORT || '8000' | ||
|
|
||
| const config = { | ||
| server: { | ||
| apiPath: topLevelGraphqlPath, |
There was a problem hiding this comment.
Can you rename this to graphqlEndpoint and move it under the graphqlConfig object?
darahayes
reviewed
Aug 21, 2018
server/config/index.js
Outdated
| @@ -28,17 +28,19 @@ if (process.env.PLAYGROUND_VARIABLES_FILE) { | |||
| } | |||
| } | |||
|
|
|||
| const topLevelGraphqlPath = '/graphql' | |||
There was a problem hiding this comment.
Can you rename this to graphqlEndpoint?
darahayes
approved these changes
Aug 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Branch that is going to be used for collaboration for
NOTES: Pushed helper files that should not land into master only to help and point out preconfigured application cluster. They going to be removed after
Verification steps
Verification will focus on memeolist example.
We will need to run memeolist without keycloak
npm run dev:memeo>Memeolist with keycloak.
npm run dev:keymemeo> Initializing Keycloak authentication