Skip to content
This repository has been archived by the owner on May 31, 2019. It is now read-only.

feat: initial empty hasRole implementation #61

Merged
merged 3 commits into from
Aug 21, 2018
Merged

Conversation

darahayes
Copy link
Contributor

Motivation

This PR provides a skeleton implementation for a hasRole directive which can be applied to a schema.

https://www.apollographql.com/docs/graphql-tools/schema-directives.html#Enforcing-access-permissions

This skeleton implementation is where we can now figure out how to do the integration with keycloak.

@darahayes darahayes requested a review from aliok as a code owner August 21, 2018 13:16
@coveralls
Copy link

coveralls commented Aug 21, 2018

Pull Request Test Coverage Report for Build 533

  • 5 of 12 (41.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.195%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/lib/schemaDirectives/hasRole.js 4 11 36.36%
Totals Coverage Status
Change from base Build 524: -0.5%
Covered Lines: 835
Relevant Lines: 982

💛 - Coveralls

@darahayes darahayes requested a review from wtrocki August 21, 2018 16:02
Copy link
Contributor

@wtrocki wtrocki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified with android app

@darahayes darahayes merged commit 27cee76 into master Aug 21, 2018
@darahayes darahayes deleted the directives-spike branch August 21, 2018 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants