-
Notifications
You must be signed in to change notification settings - Fork 16
Update comment schema #82
Update comment schema #82
Conversation
@danielpassos Changes looks great. I have no specific comment, but it's best to hold off as we do not have this replicated for IOS. |
Going to create ticket to do IOS update. |
let's rebase it later and get that in after demo together with android updates. |
Good stuff. Do we need to udpate proposal? |
@wtrocki It's ready for review. I already have changed the Android and going to do the same on iOS. |
Good to be merged. I want to push that to community cluster for wider tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once merged let's put that on community cluster so we will benefit from that on mobile clients.
@darahayes Any thoughts? Should I merge it? |
@danielpassos no problems with this PR. Just one question. Why remove comments from the meme type? |
@darahayes From the memeolist app perspective:
|
@danielpassos makes perfect sense. LGTM |
This PR: