Implement Edit Data Source

[josemigallas]

JIRA: https://issues.jboss.org/browse/AEROGEAR-3544

This PR introduces big changes to the DataSourcesDialog:

• AddDataSourceDialog has been repurposed into an "abstract" BaseDataSourceDialog.
• AddDataSourceDialog and EditDataSourceDialog are new children classes that shares common validation logic.
• Each Component implement a different query (create and update).
• BaseDataSourceDialog has "abstract" methods that children classes must implement in order to correctly setup things like title, disabled forms, the submit button.

Important changes in DataSourcesContainer:

• A new state property has been created selectedDataSource that is updated whenever the "Edit" option under the three dots dropdown is selected. That property is then passed into the appropriate modal as a prop. This approach could (or would) be used to "Delete Data Source" as well. Pinging @cfoskin .

[pb82]

Can be a constant instead of a function if all it does is return false.

[josemigallas]

TL;DR: NO 😄
This is an implementation of super.isDisabled().
What it is for? It determines which FormControls are disabled. For example when adding, you want all of them available (maybe, for now) but in case of editing, you want to disable "Data Source Type". If you take a look at BaseDataSourceDialog, all the forms have this property disabled={this.isDisabled(<control-id>)}.
Example: Let's say while creating a Postgres data source, you want to enforce timestamp data, then you could do this by adding the condition inside this method:

isDisabled(controlId) {
    if (controlId === "timestampData" && this.state.type === DataSourceType.Postgres) {
        return true;
    }
    return false;
}

[pb82]

Ah thanks for the explanation ;-)

[pb82]

Verified locally

[psturc]

Verified the functionality, just a little detail about the buttons naming:

• JIRA description says we should change the "Add" button to "Save"
• changed name of the button (Edit) is displayed also in the form when I'm adding a new data source

[darahayes]

Great work @josemigallas!

[josemigallas]

@darahayes I think I understand what you really meant in last PR with this field. At that time I didn't realize these "values" really belonged to config.options. I think it will work with a single generic options that contains all the different possibilities.

[josemigallas]

Sorry wrong line, I meant line 28

[josemigallas]

@darahayes @psturc @pb82
Thank you so much for the reviews.. if only you could do a quick review it again 😅

• Fixed dialog button name
• DataSource full editable (name and options/config)
• Some minor refactorizations

New changes

[pb82]

Verified latest changes