AGDIGGER-42 - general clean-up in docker setup #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review @luigizuccarelli @aliok |
Closed
luigizuccarelli
approved these changes
Nov 30, 2016
| <serviceAccount>${oc_serviceaccount_name}</serviceAccount> | ||
| </org.csanchez.jenkins.plugins.kubernetes.PodTemplate> | ||
| <org.csanchez.jenkins.plugins.kubernetes.PodTemplate> | ||
| <name>android</name> |
There was a problem hiding this comment.
@wtrocki - As mentioned this is a hardcoded version to get the POC working. We will look at other ways to do this better
There was a problem hiding this comment.
So this defines node (android) in the pipeline, spins up an 'Android" container/slave ?
There was a problem hiding this comment.
Yes! It's actual label field bellow, but of course entire definition allows to use android label. Idea is to have one android image that would work for both :)
There was a problem hiding this comment.
Mentioned ticket: https://issues.jboss.org/browse/AGDIGGER-41
wtrocki
changed the title
|
👍 ship it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cleanup configuration to include:
Note: image already pushed to aerogear repo.
Verification steps
Try to execute local build steps
Publish image to dockerhub (to check if you have permission to do so)
Setup new PersistentVolume
Change DeploymentConfig to include new image
Expected results
Android node should be available by default.