Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Explicit containment by @contains definition #1723

Closed
wtrocki opened this issue Jul 14, 2020 · 5 comments
Closed

Explicit containment by @contains definition #1723

wtrocki opened this issue Jul 14, 2020 · 5 comments
Labels
discussion enhancement New feature or request good first issue Good for newcomers Hacktoberfest up for grabs

Comments

@wtrocki
Copy link
Contributor

wtrocki commented Jul 14, 2020

We can have @contains or @belongs annotations to explicitly mention that this object is embedded.
@machi1990
Copy link
Contributor

Another option could be @embedded

@wtrocki
Copy link
Contributor Author

wtrocki commented Jul 14, 2020

Actually @embedded is the best!

@machi1990 machi1990 added this to the graphback@0.15.0 milestone Jul 15, 2020
@craicoverflow craicoverflow added the enhancement New feature or request label Aug 21, 2020
@craicoverflow
Copy link

We have inferred implicit relationships through non-model annotated types being identified as embedded. However that could change in the future when we get implicit relationships added (post v1) - so then this annotation will become vital.

My vote is to update the description of this issue and give it a Hacktoberfest label.

@machi1990 machi1990 mentioned this issue Sep 9, 2020
Open
6 tasks
@craicoverflow craicoverflow removed this from the Graphback 1.0-beta milestone Sep 15, 2020
@RinkiyaKeDad
Copy link
Contributor

I'd like to work on this. Can you please provide me with a bit more details to get started on? Thanks.

@craicoverflow
Copy link

Hi @RinkiyaKeDad I looked at this recently and it is not necessary to do, so I will close it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
discussion enhancement New feature or request good first issue Good for newcomers Hacktoberfest up for grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wtrocki @machi1990 @craicoverflow @RinkiyaKeDad