Externalize cache updates to object #104

wtrocki · 2019-03-12T11:50:55Z

Follows new approach from aerogear/aerogear-js-sdk#292
Requires to link js-SDK for the moment.

ticket:
https://issues.jboss.org/browse/AEROGEAR-8333

Verification steps

Add new item when offline
Restart mobile app (do not work in website version)
See item that was added.
Restore network - see that item is still there

StephenCoady

tested with the sdk PR. works perfectly on both web and real device 👍

wtrocki requested a review from StephenCoady March 12, 2019 11:50

wtrocki mentioned this pull request Mar 12, 2019

Add ability to pass update functions to the restore handler aerogear/aerogear-js-sdk#292

Merged

3 tasks

fix: Externalize cache updates to object

a87e92c

wtrocki force-pushed the cache-refactor branch from 4e56b86 to a87e92c Compare March 12, 2019 12:07

fix: Bump version of the voyager client

8d5c0f4

wtrocki changed the title ~~fix: Externalize cache updates to object~~ Externalize cache updates to object Mar 12, 2019

wtrocki requested review from jhellar and psturc March 12, 2019 12:40

fix: Ignore updates when no cache was populated

fc78ab9

StephenCoady approved these changes Mar 12, 2019

View reviewed changes

wtrocki merged commit c028748 into master Mar 12, 2019

wtrocki deleted the cache-refactor branch March 12, 2019 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Externalize cache updates to object #104

Externalize cache updates to object #104

wtrocki commented Mar 12, 2019 •

edited

StephenCoady left a comment

Externalize cache updates to object #104

Externalize cache updates to object #104

Conversation

wtrocki commented Mar 12, 2019 • edited

Verification steps

StephenCoady left a comment

Choose a reason for hiding this comment

wtrocki commented Mar 12, 2019 •

edited