This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
Aerogear 7693 - Create Mobile Client Service Chart #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranRoche
requested review from
wei-lee,
StephenCoady,
aidenkeating and
sedroche
camilamacedo86
approved these changes
Jul 25, 2018
wojta
reviewed
Jul 25, 2018
|
@wojta that was part of Johns work, this PR is just to add the donut chart, I left a note in the description that its best wait for us to get johns work merged first and then refactor/rebase this as needed. |
sedroche
approved these changes
Jul 26, 2018
ui/src/MobileClientServiceChart.js
Outdated
| import './styles/MobileClientServiceChart.css' | ||
|
|
||
| class MobileClientServiceChart extends Component { | ||
| viewAllServices(){ |
There was a problem hiding this comment.
This is not really part of this component. We can move it when we integrate all the components though
ciaranRoche
force-pushed
the
AEROGEAR-7693
branch
from
7cccdd8
to
8d86359
Compare
ciaranRoche
force-pushed
the
AEROGEAR-7693
branch
from
8d86359
to
277cee1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA - https://issues.jboss.org/browse/AEROGEAR-7693
Description
Based on top of @sedroche fork, this change adds a Mobile Service Chart Component. The component expects two props, the number of unbound service and bound services.
Screenshot
NOTE : gif does not capture the mouse pointer correctly
Note
Might be best to wait on @sedroche to be merged first and rebase/refactor this PR as needs be, then.