Aerogear 7692 #15
Aerogear 7692 #15
Conversation
ui/package.json
Outdated
| "react-scripts": "1.1.4" | ||
| "react-scripts": "1.1.4", | ||
| "redux": "^4.0.0", | ||
| "table-resolver": "^4.1.1" |
There was a problem hiding this comment.
I believe that we should not use ^ to define the deps since it could install an upper version with break changes which will affect the project.
StephenCoady
force-pushed
the
AEROGEAR-7692
branch
from
b9d3b7c
to
ad90060
Compare
ui/src/MobileClientBuildList.js
Outdated
| <ListGroup className="list-group-build"> | ||
| {mobileClientBuilds.map( | ||
| ( mobileClientBuild, index ) => ( | ||
| <ListGroupItem key={index}> |
There was a problem hiding this comment.
Is there a mobileClientBuild.spec.uid or mobileClientBuild.metadata.uid?
ui/src/MobileClientBuildList.js
Outdated
| </Col> | ||
| <Col md={6} className="list-group-build-item-description"> | ||
| <p className="build-info"> | ||
| {(mobileClientBuild.status.phase === "Running") ? |
There was a problem hiding this comment.
We need something similar on https://redhat.invisionapp.com/share/GRJJGUHNSET#/screens/295058245 screen.
So it might make sense to make this a component. Happy for this to be a follow up issue though.
There was a problem hiding this comment.
I might leave this as it is for now and add a note to this ticket: https://issues.jboss.org/browse/AEROGEAR-7712 to look at making this a reusable component. For now I have cleaned up the code a little bit to make it easier to read.
ui/src/MobileClientBuildList.js
Outdated
| </div> | ||
| ); | ||
| } | ||
| convertTime = (timeString) => { |
There was a problem hiding this comment.
Can you check the resource I am pretty sure this exists on it.
https://github.com/aerogear/origin-web-console/blob/aerogear-mcp/app/views/overview/_mobile-client-row.html#L100?
There was a problem hiding this comment.
using react-moment to do this now.
ui/src/styles/MobileClientBuild.css
Outdated
| } | ||
|
|
||
| .build-info { | ||
| display: inline-block; |
ui/src/styles/MobileClientBuild.css
Outdated
| display: inline-block; | ||
| } | ||
|
|
||
| .timestamp { |
There was a problem hiding this comment.
Can you namespace these generic namings?
sedroche
force-pushed
the
over-list-base
branch
2 times, most recently
from
54b725e
to
29775e5
Compare
StephenCoady
force-pushed
the
AEROGEAR-7692
branch
from
ad90060
to
d3163d5
Compare
StephenCoady
force-pushed
the
AEROGEAR-7692
branch
from
d3163d5
to
89d07dc
Compare
relies on @sedroche 's PR to be merged first.
screenshot:
