This repository has been archived by the owner on Dec 17, 2019. It is now read-only.
Aerogear 7703 - folder restructure and added sass #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaranRoche
requested review from
wei-lee,
StephenCoady,
camilamacedo86 and
sedroche
ui/package.json
Outdated
| @@ -3,6 +3,8 @@ | |||
| "version": "0.1.0", | |||
| "private": true, | |||
| "dependencies": { | |||
| "node-sass-chokidar": "^1.3.3", | |||
There was a problem hiding this comment.
IHMO we should not use ^ since it can bring break changes which may impact the project.
sedroche
approved these changes
Jul 26, 2018
ui/src/components/App.js
Outdated
| @@ -12,7 +12,7 @@ class App extends Component { | |||
| <div className="App"> | |||
| <Switch> | |||
| <Route exact path="/overview" component={Overview}/> | |||
| <Route exact path="/mobileclient/:id" component={Client}/> | |||
| <Route exact path="/mobileclien/:id" component={Client}/> | |||
ui/src/components/App.scss
Outdated
| @@ -0,0 +1,2 @@ | |||
| @import "../style/variables"; | |||
There was a problem hiding this comment.
The default layout would have this in index.scss. Why is it here now?
ciaranRoche
force-pushed
the
AEROGEAR-7703
branch
from
dc2dd95
to
9001f74
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA - https://issues.jboss.org/browse/AEROGEAR-7703
Description
Adds support to react app to allow the use of sass.
Change also includes a cleaner folder structure, adding a components folder.
Note
This change will mean heavy rebasing on any work that is currently in progress, open to suggestions on the order of when to merge this change to minimize conflicts.