AEROGEAR-1970 Run ansible scripts inside AWS EC2 instance #39
Conversation
vchepeli
force-pushed
the
t_AEROGEAR-1970
branch
4 times, most recently
from
6237cbc
to
ff53cb8
Compare
vchepeli
force-pushed
the
t_AEROGEAR-1970
branch
from
ff53cb8
to
409518d
Compare
vchepeli
force-pushed
the
t_AEROGEAR-1970
branch
from
c88129f
to
da33108
Compare
|
@AdamSaleh Looking |
| } | ||
|
|
||
| stage("Run Ansible scripts") { | ||
| def metadata_endpoint = "http://169.254.169.254/latest/meta-data" |
There was a problem hiding this comment.
does this have to be hardcoded? do we want a follow up issue to remove it or will it never change
There was a problem hiding this comment.
Yes this should be hardcoded. Thats static variable
|
@aidenkeating ok to take a quick look at this with your knowledge of the installer |
|
@vchepeli Technically, this is good to merge. |
|
@david-martin they are in Jenkinsfile. Arguments should be same, there is only AWS specific public hostname and routing suffix |
|
Thanks for the clarification @vchepeli. |
| readonly TAG="${5}" | ||
| readonly WILDCARD_DNS="${6}" | ||
| readonly ANSIBLE_SERVICE_BROKER_NAMESPACE="${7}" | ||
| readonly DOCKERHUB_USER=${1:?"[ERROR]You must provide a dockerhub username."} |
There was a problem hiding this comment.
@vchepeli I'm hitting an issue with local provsion with this change.
My dockerhub password has a symbol ) in it, which doesn't get parsed OK.
"stderr_lines": ["/bin/sh: -c: line 0: syntax error near unexpected token `)'"
Can we add back quotes around this?
There was a problem hiding this comment.
Added already. @david-martin can you try it again please?
|
@david-martin this is mostly for automation/testing. |
| @@ -58,7 +58,7 @@ | |||
| mode: u+x | |||
|
|
|||
| - name: Execute OpenShift Ansible Broker (OAB) provision script | |||
| shell: bash -e /tmp/provision-ansible-service-broker.sh "{{ dockerhub_username }}" "{{ dockerhub_password }}" "{{ dockerhub_org }}" "{{ launch_apb_on_bind }}" "{{dockerhub_tag}}" "{{ wildcard_dns_host }}" "{{ ansible_service_broker_namespace }}" | |||
| shell: "bash -e /tmp/provision-ansible-service-broker.sh {{ dockerhub_username }} {{ dockerhub_password }} {{ dockerhub_org }} {{ launch_apb_on_bind }} {{dockerhub_tag}} {{ cluster_public_ip }} {{ wildcard_dns_host }} {{ ansible_service_broker_namespace }}" | |||
There was a problem hiding this comment.
@vchepeli looks like it needs to be escaped here too. Not sure why the escaping was removed
There was a problem hiding this comment.
Not sure why the escaping was removed
There was no comment why it escapes every symbol and I removed it
|
Thanks @vchepeli 👍 |
Motivation
AEROGEAR-1970
Description
AEROGEAR-1970
Progress
Additional Notes