Bug 1153975 - Skip rsync when no deployments directory found

[mfojtik]

@matzew @fjuma please can you help me here? ;-) I don't know why the deployments directory is missing in the GIT repo template. Also there is this message:

remote: CLIENT_MESSAGE: Could not connect to WildFly management interface, 
skipping deployment verification

After 'git push' and when 'rhc app stop/start'

[matzew]

hrm, do we need WF management interface?

On Monday, October 20, 2014, Michal Fojtik notifications@github.com wrote:

@matzew https://github.com/matzew @fjuma https://github.com/fjuma
please can you help me here? ;-) I don't know why the deployments directory
is missing in the GIT repo template. Also there is this message:

remote: CLIENT_MESSAGE: Could not connect to WildFly management interface, skipping deployment verification

After 'git push' and when 'rhc app stop/start'

You can merge this Pull Request by running

git pull https://github.com/mfojtik/openshift-origin-cartridge-aerogear-push deployments

Or view, comment on, or merge it at:

#9
Commit Summary

• Bug 1153975 - Skip rsync when no deploymnets directory found

File Changes

• M bin/control
  https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/9/files#diff-0
  (8)

Patch Links:

https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/9.patch

https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/pull/9.diff

—
Reply to this email directly or view it on GitHub
#9
.

Sent from Gmail Mobile

[fjuma]

@mfojtik The deployments directory isn't included in the GIT repo template because we don't allow user deployments.

Looking into the error message.

[fjuma]

@mfojtik The error message [1] just indicates that the deployment scanner hasn't finished running yet. Notice that the getscanconfig method [2] only attempts to get the deployment scanner configuration a certain number of times and if it hasn't finished running by then, the deployment verification step gets skipped. Note though that ag-push.war and auth-server.war do still get deployed successfully.

@matzew It looks like increasing the number of attempts made in the getscanconfig method should improve things but it might take some testing to figure out what number of attempts would be good to use.

Let me know if there are any questions about this.

[1] https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/blob/master/bin/control#L40
[2] https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/blob/master/bin/control#L18

[matzew]

@fjuma so the 'getscanconfig' is required?

any numbers on it we could borrow from other cartridges, based on WF
cartridge

thanks!

On Monday, October 20, 2014, Farah Juma notifications@github.com wrote:

@mfojtik https://github.com/mfojtik The error message [1] just
indicates that the deployment scanner hasn't finished running yet. Notice
that the getscanconfig method [2] only attempts to get the deployment
scanner configuration a certain number of times and if it hasn't finished
running by then, the deployment verification step gets skipped. Note though
that ag-push.war and auth-server.war do still get deployed successfully.

@matzew https://github.com/matzew It looks like increasing the number
of attempts made in the getscanconfig method should improve things but it
might take some testing to figure out what number of attempts would be good
to use.

Let me know if there are any questions about this.

[1]
https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/blob/master/bin/control#L40
[2]
https://github.com/aerogear/openshift-origin-cartridge-aerogear-push/blob/master/bin/control#L18

—
Reply to this email directly or view it on GitHub
#9 (comment)
.

Sent from Gmail Mobile

[fjuma]

@matzew The 'getscanconfig' method is used by both the AS 7 cartridge and the WildFly cartridge. They both use at most 4 attempts, which is what the AeroGear cartridge was using as well. Michal has updated this PR to use at most 10 attempts instead.

[fjuma]

@mfojtik Merged, thanks!