Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regard the overlapping #9

Closed
hornig opened this issue May 20, 2018 · 2 comments
Closed

regard the overlapping #9

hornig opened this issue May 20, 2018 · 2 comments
Assignees

Comments

@hornig
Copy link
Contributor

hornig commented May 20, 2018

DirectDemod/noaa_cli.py

Lines 21 to 23 in 420a063

for i in chunker.chunker(sigsrc).getChunks[:]:
sig = comm.commSignal(constants.IQ_SDRSAMPRATE, sigsrc.read(*i)).offsetFreq(constants.IQ_FREQOFFSET).filter(filters.blackmanHarris(151)).bwLim(constants.IQ_FMBW).funcApply(fmDemod.fmDemod().demod).bwLim(constants.NOAA_AUDSAMPRATE, True)
audioOut.extend(sig)

most filters need more samples. these samples also range outside the current chunk into the next chunk. please regard it here and in further similar implementations.

7andahalf added a commit that referenced this issue May 21, 2018
7andahalf added a commit that referenced this issue May 21, 2018
@7andahalf
Copy link
Member

Currently, overlapping in 'filters' and 'FM demodulator' is fixed. Further investigation regarding if chunking affects 'bandwidth limiting' or 'frequency offsetting' will be done soon.

7andahalf added a commit that referenced this issue May 21, 2018
7andahalf added a commit that referenced this issue May 21, 2018
@7andahalf
Copy link
Member

Fixed overlapping due to 'bandwidth limiting' or 'frequency offsetting'. Closing the issue. Please re-open in case of any discrepancies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants