Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssl_check.sh #499

Closed
wants to merge 1 commit into from
Closed

Conversation

v-anton
Copy link

@v-anton v-anton commented Dec 29, 2022

What does this PR do?
This PR updates the script to check the OpenSSL version and copy files from the appropriate directory.

Why is this change necessary?
The old script used the wrong syntax to extract the first element from the text array, resulting in the incorrect value used in the if statement. This caused the script to execute the else block even when the OpenSSL version was 3.

The new script extracts the first word from the version string and checks whether it starts with "Libre." It also removes the version number from the second element of the array and splits it into dots to extract the major version number. This allows the script to determine the major version number correctly and whether the version is LibreSSL or OpenSSL.

How does this PR fix the issue?
The PR fixes the issue by using the correct syntax to extract the first element from the text array and extract the major version number from the version string. This allows the script to determine the major version number correctly and whether the version is LibreSSL or OpenSSL, enabling it to copy the files from the appropriate directory.

Are there any side effects?
There should not be any side effects as the changes are limited to the script for checking the OpenSSL version and copying files.

Other information
N/A

@DomPeliniAerospike
Copy link
Collaborator

@v-anton thank you for the pull request. We are fixing this with 5.2.1 releasing in a few days. However, we will be changing this script to a javascript file to increase compatibility with Windows releases. If you are still having issues after the release, please let me know!

@v-anton
Copy link
Author

v-anton commented Feb 13, 2023

@DomPeliniAerospike Sure, no problem! Thanks for the feedback!

@v-anton v-anton closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants