random scan_id not random enough

[courtneycouch]

If this:

aerospike-client-nodejs/src/main/client/query_foreach.cc

Lines 467 to 471 in 80d423f

	data->scan_id = 0;
	int32_t dummy_id = 0;
	srand(time(NULL));
	dummy_id = rand();
	data->scan_id = dummy_id;

gets hit more than once in a second then the scan_id gets duplicated and you end up with errors like:

WARNING (scan): (thr_tscan.c::807) not starting scan 1926250993 because rchash_put() failed with error -4

It's not likely to happen in production but for pre-deployment testing it's possible for scans to happen very close together (as fast as tests complete). So we're finding we have to put these silly 1 second delays to keep scan_id collisions from happening.

[GayathriKaliyamoorthy]

Hi,

We do not expect multiple requests for full system scan within a second. If you have such requirements, we can enhance the API, to accept scanID from the application. You can raise a pull request with the enhancements. We accept pull requests. :)

Thanks.

[tracker1]

I'm not familiar with the internals, but if the scanID isn't sequential, why isn't crypto randomBytes, or the uuid module not used?

[wchu-citrusleaf]

We will be fixing this shortly

[GayathriKaliyamoorthy]

Fix is available from release 1.0.49.