Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend search space for query searches #43

Closed
KrisDavie opened this issue Feb 28, 2018 · 9 comments
Closed

Extend search space for query searches #43

KrisDavie opened this issue Feb 28, 2018 · 9 comments
Assignees
Labels

Comments

@KrisDavie
Copy link
Contributor

Include clusterings (i.e. all clusters) and individual clusters from each clustering

@KrisDavie KrisDavie added enhancement New feature or request backend labels Feb 28, 2018
@KrisDavie KrisDavie self-assigned this Feb 28, 2018
@KrisDavie
Copy link
Contributor Author

Resolved in b01b378
@kreftl I think we might have to change how something works, although I don't know what, to be able to get this working properly.

Locally, I had to add this to API.jsx (line 22-26)

'Clustering: Seurat resolution 2.0': {
    0: {type: '', value: ''},
    1: {type: '', value: ''},
    2: {type: '', value: ''}
},

and add a few sections for clusters in FeatureSearchBox (93-98)

} else if (response.featureType[i].startsWith('Clustering: ')) {
	clusters.push({
		"title": response.feature[i],
		"type": response.featureType[i]
		});
}

line 103

clusters = {"name": "clusters", "results": clusters.slice(0, 10)}

and lines 112-114

if (clusters['results'].length && (this.props.type == 'all' || this.props.type == 'clusters')) {
	res.push(clusters);
}

The problem is, it doesn't show Clustering: Seurat resolution 2.0' in the search box, and we would need a section in the frontend, specific to each clustering. I don't know how easy this would be to solve or whether the backend implementation could be altered to help.

Mind posting your thoughts?

@kreftl
Copy link

kreftl commented Mar 1, 2018

that for sure requires a change, let me investigate that in detail...

but is there a need to put Clustering: Seurat resolution 2.0 in the searchbox, or only e.g. cluster
and put the details of clusterings etc in some general page, e.g. proper dataset info ?

@KrisDavie
Copy link
Contributor Author

My only thought there is that we were planning on being able to put multiple clusterings in the loom files (i.e. different resolutions in Seurat, resulting in more clusters), and in that case, some clusters from each clustering would have the same name, but some would be different. Also then we would have to somehow distinguish 'Unannotated' clusters from each clustering too.

Maybe we could have a way to select which clustering you want to search now I think about it

@kreftl
Copy link

kreftl commented Mar 1, 2018

i would use the cluster id somehow instead of putting the complete cluster name everytime
it will result in less data exchanged between the FE and BE
what about putting 'cluster#'+clusterID as a featureType ?

@kreftl kreftl reopened this Mar 1, 2018
@KrisDavie
Copy link
Contributor Author

That would work, but it would be nice for the user to be able to see the full description, think you can make that happen?
I will prep a new loom file soon, with a second clustering in it and hopefully the subclusters too

@kreftl
Copy link

kreftl commented Mar 1, 2018

the description anyhow comes in loom metadata, so i dont need to send it each time for feature query, there id only will be sufficient

how do we structure the subclusters ?

@KrisDavie
Copy link
Contributor Author

Working on the subclusters, they are in the loom file now, but I need to decide if this is the most efficient way of putting them in there and then write the backend functions for you. Should be an update today (I hope!)

@KrisDavie
Copy link
Contributor Author

depends on #56

@KrisDavie
Copy link
Contributor Author

Old issue. Already implemented. Further enhancements will be tracked under new specific issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants