-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend search space for query searches #43
Comments
Resolved in b01b378 Locally, I had to add this to API.jsx (line 22-26) 'Clustering: Seurat resolution 2.0': {
0: {type: '', value: ''},
1: {type: '', value: ''},
2: {type: '', value: ''}
}, and add a few sections for clusters in FeatureSearchBox (93-98) } else if (response.featureType[i].startsWith('Clustering: ')) {
clusters.push({
"title": response.feature[i],
"type": response.featureType[i]
});
} line 103 clusters = {"name": "clusters", "results": clusters.slice(0, 10)} and lines 112-114 if (clusters['results'].length && (this.props.type == 'all' || this.props.type == 'clusters')) {
res.push(clusters);
} The problem is, it doesn't show Mind posting your thoughts? |
that for sure requires a change, let me investigate that in detail... but is there a need to put |
My only thought there is that we were planning on being able to put multiple clusterings in the loom files (i.e. different resolutions in Seurat, resulting in more clusters), and in that case, some clusters from each clustering would have the same name, but some would be different. Also then we would have to somehow distinguish 'Unannotated' clusters from each clustering too. Maybe we could have a way to select which clustering you want to search now I think about it |
i would use the cluster id somehow instead of putting the complete cluster name everytime |
That would work, but it would be nice for the user to be able to see the full description, think you can make that happen? |
the description anyhow comes in loom metadata, so i dont need to send it each time for feature query, there id only will be sufficient how do we structure the subclusters ? |
Working on the subclusters, they are in the loom file now, but I need to decide if this is the most efficient way of putting them in there and then write the backend functions for you. Should be an update today (I hope!) |
depends on #56 |
Old issue. Already implemented. Further enhancements will be tracked under new specific issues. |
Include clusterings (i.e. all clusters) and individual clusters from each clustering
The text was updated successfully, but these errors were encountered: