Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProposalStateType, IntegratorStateType, etc should be namedtuples #67

Closed
rlouf opened this issue Jul 3, 2022 · 1 comment · Fixed by #99
Closed

ProposalStateType, IntegratorStateType, etc should be namedtuples #67

rlouf opened this issue Jul 3, 2022 · 1 comment · Fixed by #99
Assignees
@zoj613
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature

Comments

@rlouf
Copy link
Member

rlouf commented Jul 3, 2022

Even if we can only pass tensors in functions used in scan this will make this code a lot easier to follow, and ready in case it becomes possible to pass namedtuples in scan.

Originally posted by @brandonwillard in #7 (comment)
@rlouf rlouf added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature labels Jul 4, 2022
@zoj613 zoj613 self-assigned this May 2, 2023
@zoj613
Copy link
Member

zoj613 commented May 9, 2023

What would be attributes of a TerminationState tuple? @rlouf

@zoj613 zoj613 mentioned this issue May 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zoj613 zoj613

Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed refactoring A change that improves the codebase but doesn't necessarily introduce a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve readability by packing frequently used variables into namedtuples. zoj613/aehmc
2 participants
@rlouf @zoj613