Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update step size dtypes #87

Open
brandonwillard opened this issue Jan 3, 2023 · 1 comment
Open

Update step size dtypes #87

brandonwillard opened this issue Jan 3, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request refactoring A change that improves the codebase but doesn't necessarily introduce a new feature

Comments

@brandonwillard
Copy link
Member

In #86, I updated the step size dtypes to int64, but I imagine it would be better to perform that conversion somewhere within AeHMC; however, I don't know the best place for that at the moment.

@rlouf, if you get a minute, tell me where you think an astype could be performed so that users can specify int32 and avoid those Scan casting issues.

Originally posted by @brandonwillard in #86 (comment)

@brandonwillard brandonwillard added the refactoring A change that improves the codebase but doesn't necessarily introduce a new feature label Jan 3, 2023
@brandonwillard brandonwillard added the enhancement New feature or request label Jan 3, 2023
@rlouf
Copy link
Member

rlouf commented Mar 10, 2023

As far as I understand, you cast the number of steps to int64. The high-level entry points of the library, and that you might want to use in a Scan are here:

It seems that you've covered the internal ones already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring A change that improves the codebase but doesn't necessarily introduce a new feature
Projects
None yet
Development

No branches or pull requests

2 participants