Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use absolute instead of abs #1420

Open
Tracked by #1424
rlouf opened this issue Feb 13, 2023 · 6 comments
Open
Tracked by #1424

Use absolute instead of abs #1420

rlouf opened this issue Feb 13, 2023 · 6 comments

Comments

@rlouf
Copy link
Member

rlouf commented Feb 13, 2023

And deprecate aesara.tensor.math.abs.

https://numpy.org/doc/stable/reference/generated/numpy.absolute.html#numpy.absolute

@Kd-Here
Copy link

Kd-Here commented Feb 17, 2023

Hey is this right place?
Where I should make changs of deprecate

_abs = builtins.abs

@rlouf
Copy link
Member Author

rlouf commented Feb 17, 2023

Line 1049 in this file. If you want to see what kind of changes you would need to make you can check out #1414.

@Kd-Here
Copy link

Kd-Here commented Feb 24, 2023

Thanks for giving that refference.
Like true_div changed to true_divide I need to change do same with abs
Correct me if wrong-

  1. Need to change abs to absolute throughout the codebase. I made changes in commit.
  2. Add deprecate to abs

@rlouf
Copy link
Member Author

rlouf commented Feb 24, 2023

Sounds about right. You can look at this PR to have an idea of all the places where you will have to make changes.

@theyashl
Copy link

Hi @rlouf , are you working on this issue?

@rlouf
Copy link
Member Author

rlouf commented Jun 12, 2023

Not at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants