Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Scan Op utils #19

Closed
brandonwillard opened this issue Jul 21, 2020 · 2 comments
Closed

Add new Scan Op utils #19

brandonwillard opened this issue Jul 21, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@brandonwillard
Copy link
Member

Let's consider adding the Scan utilities from pymc-devs/symbolic-pymc#114 (e.g. the improved ScanArgs class and convert_outer_out_to_in function).

These would also help with a much needed general refactoring and simplification of Scan.
@brandonwillard brandonwillard added the enhancement New feature or request label Jul 21, 2020
@brandonwillard brandonwillard mentioned this issue Jul 26, 2020
Closed
@ricardoV94
Copy link
Contributor

ricardoV94 commented Jul 29, 2021 •
edited

The ScanArgs was already introduced.

You mentioned a convert_outer_out_to_in function, is that still missing/relevant?

@brandonwillard
Copy link
Member Author

You mentioned a convert_outer_out_to_in function, is that still missing/relevant?

It's in the Scan PR in AePLL, but doesn't really need to be in this repo at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonwillard @ricardoV94