-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement grad for GammaInc #74
Comments
Thanks for reporting -- want to do a PR? |
I'd be up for working on a PR, but I've never submitted a PR on the PyMC3 codebase before. If you think this can be tackled by a newcomer, I can give it a go. |
I think you'd learn a lot and we'll definitely help out. |
brandonwillard
changed the title
Implement Gamma
Implement grad for Gamma/GammaLn and GammaInc
Oct 12, 2020
logcdf
Derivative
brandonwillard
changed the title
Implement grad for Gamma/GammaLn and GammaInc
Implement grad for GammaInc
Oct 12, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Gamma
logcdf
does not have a gradient function implemented.Example:
Trying to sample from this raises an error:
MethodNotDefined: ('grad', <class 'theano.scalar.basic_scipy.GammaInc'>, 'GammaInc')
Note: the
logcdf
derivative should be available as a function of thelogpdf
. It would be great to have this implemented. For example, this would mean my use case above (generating a discretised distribution) can be implemented.The text was updated successfully, but these errors were encountered: