-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythonic style #44
Comments
|
|
Questions regarding possible contributions and how well they would be received.
It seems the visualization module of BCT has not been ported to bctpy. Is this intentional? Is this planned for a future version?
Some names are not standardized across modules. For example,
clustering.py
usesclustering_coef_wd
, wherewd
stands for weighted directed, whereascore.py
usesassortativity_wei
for weighted networks. I know this comes from the original BCT, but I think there's a point in making this package as good-quality as possible (and that includes consistent naming conventions).Related to previous one. Is there interest in trying to make the package more pythonic, instead of a direct translation of BCT? For example,
There are 546 lines which deviate from
flake8
styling guidelines. Is there interest in making bctpy adhere more to python standards?If so, I would like to discuss the best way of setting up a PR.
The text was updated successfully, but these errors were encountered: