Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check if record exists on delete keys mutation #1312

Merged
merged 1 commit into from
May 11, 2023

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented May 11, 2023

Protection to avoid:

2023-05-11 14:37:19.566 [info] Application ae_mdw exited: bad return value: {{AeMdw.Application, :start_phase, [:dedup_accounts, :normal, []]}, {:EXIT, {%RuntimeError{message: "Txn delete on missing key: Elixir.AeMdw.Db.Model.AsyncTask, {1682903942917498353, :store_acc_balance}"}, [{AeMdw.Database, :delete, 3, [file: 'lib/ae_mdw/database.ex', line: 157]}, {AeMdw.Db.TxnDbStore, :delete, 3, [file: 'lib/ae_mdw/db/txn_db_store.ex', line: 42]}, {AeMdw.Db.State, :delete, 3, [file: 'lib/ae_mdw/db/state.ex', line: 152]}, {Enum, :"-reduce/3-lists^foldl/2-0-", 3, [file: 'lib/enum.ex', line: 2396]}, {:maps, :fold_1, 3, [file: 'maps.erl', line: 233]}, {Enum, :"-reduce/3-lists^foldl/2-0-", 3, [file: 'lib/enum.ex', line: 2396]}, {AeMdw.Db.TxnDbStore, :transaction, 1, [file: 'lib/ae_mdw/db/txn_db_store.ex', line: 23]}, {AeMdw.Db.State, :commit, 3, [file: 'lib/ae_mdw/db/state.ex', line: 56]}]}}}

@jyeshe jyeshe requested a review from sborrazas May 11, 2023 14:49
@jyeshe jyeshe self-assigned this May 11, 2023
@jyeshe jyeshe merged commit 1c0ff5e into master May 11, 2023
7 checks passed
@jyeshe jyeshe deleted the safer-delete-keys branch May 11, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants