Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add transactions count to websocket keyblock #1382

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

jyeshe
Copy link
Member

@jyeshe jyeshe commented Jun 5, 2023

closes #1291

@jyeshe jyeshe self-assigned this Jun 12, 2023
@jyeshe jyeshe requested a review from sborrazas June 12, 2023 17:45
@jyeshe jyeshe marked this pull request as ready for review June 12, 2023 17:45
@jyeshe jyeshe merged commit 490d379 into master Jun 13, 2023
7 checks passed
@jyeshe jyeshe deleted the ws-gen-txs-count branch June 13, 2023 12:17
@janmichek
Copy link

Hi, I am taking over this issue. I think this was a mistaken requirement. The count of transactions per keyblock should be served in the microblock-triggered message.
When the keyblock is mined and the message fired, tx count and microblocks count will always be 0 / null. Right?

image

@janmichek
Copy link

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Websocket serves different data than the REST endpoints
3 participants