feat: add approximate_expiration_time to oracles #1390
Conversation
| def last_gen_and_time(state) do | ||
| case State.prev(state, Model.Block, nil) do | ||
| {:ok, {height, _mbi}} -> | ||
| Model.block(hash: block_hash) = State.fetch!(state, Model.Block, {height, -1}) | ||
|
|
||
| {height, block_time(block_hash)} |
There was a problem hiding this comment.
Would it be possible to leave the block_time to be used only by the height_to_time? This way the block read would happen once and the conversion from gen to time is left only for the moment it is used (with the additional benefit of one less parameter and skipping the need for last_gen_and_time).
There was a problem hiding this comment.
This would cause to retrieve the time for the last block multiple times when requesting it for a list of oracles: https://github.com/aeternity/ae_mdw/pull/1390/files#diff-d800a239402e86baa72793fe422de5f1d247ad3452b2efd3ee981cede91c038eR298
lib/ae_mdw/oracles.ex
Outdated
| @@ -332,6 +333,8 @@ defmodule AeMdw.Oracles do | |||
| active: is_active?, | |||
| active_from: register_height, | |||
| expire_height: expire_height, | |||
| approximate_expiration_time: | |||
There was a problem hiding this comment.
what you think of estimated_expire_time? it sounds to give a closer idea of the time it will expire and not the duration until it expires, following the style of expire_height .
There was a problem hiding this comment.
Good call on leaving expire instead of expiration to follow expire_height format. Left the approximate because it works well for both past and future dates
sborrazas
force-pushed
the
oracles-exp-time
branch
from
da689b3
to
07ba559
Compare
refs #1371