chore: make the wealth rank task work with the database instead of AsyncStore and ets #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sborrazas
changed the title
yaboiishere
changed the title
yaboiishere
force-pushed
the
make-wealth-sync
branch
from
33c0839
to
2ce0bc1
Compare
yaboiishere
changed the title
AsyncStore and ets
yaboiishere
force-pushed
the
make-wealth-sync
branch
from
9016fc2
to
da6c58c
Compare
vatanasov
reviewed
Jun 12, 2024
lib/ae_mdw/sync/wealth_rank.ex
Outdated
| end | ||
| end | ||
|
|
||
| @spec update_balances(State.t(), balances()) :: State.t() |
There was a problem hiding this comment.
Isn't this function used only in the tests? If so, isn't it better to be placed in the test utils modules?
sborrazas
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.