Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: present aexn tokens using state from the StatePlug #759

Merged
merged 3 commits into from
Jun 30, 2022
Merged

chore: present aexn tokens using state from the StatePlug #759

merged 3 commits into from
Jun 30, 2022

Conversation

sborrazas
Copy link
Contributor

No description provided.

@sborrazas sborrazas requested review from thepiwo and jyeshe June 30, 2022 11:25
@sborrazas sborrazas self-assigned this Jun 30, 2022
jyeshe
jyeshe requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad unit tests coverage was helpful (:

@sborrazas
Copy link
Contributor Author

@jyeshe I've now fixed the tests that broke with that last commit.

Out of curiosity, what is it that you found useful about coverage for this PR?

@sborrazas sborrazas requested a review from jyeshe June 30, 2022 13:46
@jyeshe
Copy link
Member

jyeshe commented Jun 30, 2022

@jyeshe I've now fixed the tests that broke with that last commit.

Out of curiosity, what is it that you found useful about coverage for this PR?

Two benefits when increased or at least kept at the same percentage implementing unit tests for new features:

  1. If you receive a review request after one hour of the last commit and there are unit tests that have failed you don't need to waste time reviewing code that needs to be changed.
  2. Unit test might have detected errors that a code review by reading or partial manual tests wouldn't.

@sborrazas sborrazas merged commit 68f04f5 into master Jun 30, 2022
@sborrazas sborrazas deleted the aexn-state branch June 30, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepiwo thepiwo thepiwo approved these changes

@jyeshe jyeshe jyeshe approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sborrazas @jyeshe @thepiwo