feat: display tx hash instead of txi when tx_hash=true #789
Conversation
| Keyword.get(opts, :expand?, false) -> | ||
| Txs.fetch!(state, txi) | ||
|
|
||
| Keyword.get(opts, :tx_hash?, false) -> | ||
| Enc.encode(:tx_hash, Txs.txi_to_hash(state, txi)) |
There was a problem hiding this comment.
It would be good for the user to get some kind of exception like this otherwise the param gets ignored silently. This would indicate that it should be used one param or the other.
There was a problem hiding this comment.
Done, added this validation on the PaginationPlug so we didn't have to on every top module
| else | ||
| txi | ||
| cond do | ||
| Keyword.get(opts, :expand?, false) -> |
| {:ok, _encoded_tx_hash}, | ||
| :aeser_api_encoder.safe_decode(:tx_hash, tx_hash) |
There was a problem hiding this comment.
It could be checked that besides present the tx_hash is correct, here on integration or on unit tests.
An integration test for oracle would be missing or if the tx_hash becomes validated on oracle unit test it would be enough.
There was a problem hiding this comment.
Done, added oracle test which validates this now
I think it's enough to test that at least one tx hash was converted, testing that the conversion txi->hash is not always the same seems to be too far fetch for values that were chosen randomly (8989-> th_5aUc7Xqk3TkG38XVjCzZPAWc1geGFfjGcgEytcZAFe3FJyn4g) |
refs #764